Add action widgets, open page widgets, and gauges on the Lock Screen #2830

literally-anything · 2024-06-27T22:27:41Z

Summary

Allow action widget, open page widget, and watchOS style complications to be available on the iOS Lock Screen.

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

home-assistant

Hi @literally-anything

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

bgoncal · 2024-06-30T22:31:58Z

Looking good! I will manually test and review the PR this week

codecov · 2024-06-30T22:48:18Z

Codecov Report

Attention: Patch coverage is 7.21649% with 90 lines in your changes missing coverage. Please review.

Project coverage is 27.53%. Comparing base (6c34210) to head (7555425).
Report is 145 commits behind head on master.

Files	Patch %	Lines
...AppIntents/Widget/Gauge/WidgetGaugeAppIntent.swift	0.00%	37 Missing ⚠️
...Extensions/AppIntents/IntentServerAppEntitiy.swift	0.00%	26 Missing ⚠️
...ntents/Widget/Details/WidgetDetailsAppIntent.swift	0.00%	16 Missing ⚠️
...ficationCommands/NotificationsCommandManager.swift	12.50%	7 Missing ⚠️
.../SharedPush/Sources/NotificationParserLegacy.swift	60.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2830      +/-   ##
==========================================
- Coverage   27.54%   27.53%   -0.02%     
==========================================
  Files         311      357      +46     
  Lines       31699    24572    -7127     
==========================================
- Hits         8733     6767    -1966     
+ Misses      22966    17805    -5161

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bgoncal · 2024-06-30T22:49:36Z

btw bundle exec fastlane autocorrect to fix lint issues

bgoncal

Great job! Just some general improvements that I could spot

Sources/Extensions/AppIntents/Widget/Details/WidgetDetailsAppIntent.swift

Sources/Extensions/AppIntents/Widget/Details/WidgetDetailsAppIntentTimelineProvider.swift

Sources/Extensions/AppIntents/Widget/Gauge/WidgetGaugeAppIntent.swift

Sources/Extensions/Widgets/Actions/WidgetActions.swift

Sources/Extensions/Widgets/Common/WidgetBasicContainerView.swift

Sources/Extensions/Widgets/Gauge/WidgetGauge.swift

Sources/Shared/Notifications/NotificationCommands/NotificationsCommandManager.swift

home-assistant · 2024-07-01T09:31:08Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

bgoncal · 2024-07-01T11:15:00Z

You also need this code on line 81 in LegacyNotificationParserImpl, if you have time would be nice to make it all an enum

case "reload_widgets":
                return .init("reload_widgets")

Sources/Shared/Notifications/NotificationCommands/NotificationsCommandManager.swift

literally-anything · 2024-07-02T21:18:00Z

I haven’t managed to test the notification commands at all. I can’t seem to get my own firebase app connected to APNs properly.

Sources/PushServer/SharedPush/Sources/NotificationParserLegacy.swift

bgoncal · 2024-07-03T09:19:55Z

Sources/Shared/Notifications/NotificationCommands/NotificationsCommandManager.swift

@@ -19,6 +20,9 @@ public class NotificationCommandManager {
    public init() {
        register(command: "request_location_update", handler: HandlerLocationUpdate())
        register(command: "clear_notification", handler: HandlerClearNotification())
+        if #available(watchOS 9, *) {
+            register(command: "reload_widgets", handler: HandlerReloadWidgets())


Use the created enum, this is a good example of where things could go wrong, now you are registering "reload_widgets" but on that enum is "update_widgets"

This is still incorrect

Also, let's remove the #available there and move this inside the #if os(iOS) on line 26, since it doesnt make sense to have it for watch anyways

bgoncal · 2024-07-03T09:33:41Z

Localization didn't work on my side, do you see it working fine when you edit the widget?

bgoncal · 2024-07-03T09:34:05Z

I haven’t managed to test the notification commands at all. I can’t seem to get my own firebase app connected to APNs properly.

I just manually tested it, and after the changes related to the enum above, all works well, we just need to add a note in the documentation telling the user that they can't keep reloading the widgets in a short period of time, since iOS will refuse to do it that often.

Btw, after these changes above we are good to merge, could you just update the docs?
https://companion.home-assistant.io/docs/notifications/notification-commands

repo:
https://github.com/home-assistant/companion.home-assistant

literally-anything · 2024-07-03T23:25:15Z

Localization was working fine for me until I changed my locale. The localized string resources don’t seem to have a fallback for when the string isn’t in the current locale unless you explicitly set it, so I just added defaults for English.

….swift Co-authored-by: Bruno Pantaleão Gonçalves <[email protected]>

Sources/Shared/Notifications/NotificationCommands/NotificationsCommandManager.swift

bgoncal

LGTM!

bgoncal · 2024-07-08T08:52:47Z

Anything else you want to add? Otherwise I can merge it (Asking because you didnt hit the "ready to review" button)

Stale

literally-anything · 2024-07-08T11:07:08Z

Oh, no I just forgot to hit the button

bgoncal · 2024-07-08T11:22:19Z

Oh, no I just forgot to hit the button

Thank you for your contribution! Don't forget a small update in https://companion.home-assistant.io/docs/notifications/notification-commands

repo:
https://github.com/home-assistant/companion.home-assistant

dnestico · 2024-07-28T18:26:43Z

Sorry for commenting but just wondering if any documentation for these new widgets will be added?

literally-anything added 4 commits June 27, 2024 00:03

Move the accessoryCircular button to a separate file

f718b01

Add accessoryCircular family to the actions widget

f3b50ee

Add accessoryCircular family to the open page widget

aff4022

Merge branch 'home-assistant:master' into master

55c727a

home-assistant bot added the cla-needed label Jun 27, 2024

home-assistant bot previously requested changes Jun 27, 2024

View reviewed changes

home-assistant bot added cla-recheck cla-signed and removed cla-recheck cla-needed labels Jun 27, 2024

literally-anything added 4 commits June 27, 2024 18:29

Merge branch 'home-assistant:master' into master

5952a2e

Add base gauge widget

de5ed06

Add localization for the gauge widget

996ab5d

Add a push notification to reload the gauge widget

a76099b

literally-anything changed the title ~~Add action and open page widgets on the Lock Screen~~ Add action widgets, open page widgets, and gauges on the Lock Screen Jun 30, 2024

literally-anything added 2 commits June 30, 2024 08:31

Use server name instead of remote name for the server picker

cb1366e

Fix log message

4b32660

literally-anything marked this pull request as ready for review June 30, 2024 13:43

literally-anything marked this pull request as draft June 30, 2024 13:51

Add placeholders and the details widget

41ab442

literally-anything marked this pull request as ready for review June 30, 2024 15:14

Chnage the gauge and details identifiers

15bcc7c

bgoncal requested changes Jul 1, 2024

View reviewed changes

home-assistant bot marked this pull request as draft July 1, 2024 09:31

bgoncal reviewed Jul 1, 2024

View reviewed changes

Sources/Shared/Notifications/NotificationCommands/NotificationsCommandManager.swift Outdated Show resolved Hide resolved

literally-anything added 3 commits July 2, 2024 15:02

Move widget kinds to a shared enum

b1b5d8c

Merge branch 'master' into master

f1d1ec6

Localize the parameters in the widget app intents

d32bd63

Localize the strings in the GagueType app enum

adbc065

bgoncal reviewed Jul 3, 2024

View reviewed changes

Sources/PushServer/SharedPush/Sources/NotificationParserLegacy.swift Outdated Show resolved Hide resolved

bgoncal reviewed Jul 3, 2024

View reviewed changes

Add english as a default when no localizaion exists

dc6ebf7

literally-anything and others added 2 commits July 3, 2024 19:25

Update Sources/PushServer/SharedPush/Sources/NotificationParserLegacy…

8ca7e45

….swift Co-authored-by: Bruno Pantaleão Gonçalves <[email protected]>

Use the enum for the name of the command

09692fe

literally-anything mentioned this pull request Jul 3, 2024

Add update_widgets to the list of notification commands on iOS home-assistant/companion.home-assistant#1073

Closed

Merge branch 'master' into master

5533735

bgoncal requested changes Jul 5, 2024

View reviewed changes

Sources/Shared/Notifications/NotificationCommands/NotificationsCommandManager.swift Outdated Show resolved Hide resolved

literally-anything added 3 commits July 5, 2024 07:06

Merge branch 'master' into master

cc1ae8f

Make update_widgets only availible on iOS

831e7f2

Merge remote-tracking branch 'refs/remotes/origin/master'

7555425

bgoncal approved these changes Jul 8, 2024

View reviewed changes

literally-anything marked this pull request as ready for review July 8, 2024 11:06

home-assistant bot requested a review from bgoncal July 8, 2024 11:06

bgoncal merged commit e364507 into home-assistant:master Jul 8, 2024
8 checks passed

literally-anything mentioned this pull request Jul 10, 2024

update_widgets command only works with the app the foreground #2845

Closed

AndreasBackx mentioned this pull request Sep 3, 2024

Cannot configure Lock Screen Widgets #2973

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add action widgets, open page widgets, and gauges on the Lock Screen #2830

Add action widgets, open page widgets, and gauges on the Lock Screen #2830

literally-anything commented Jun 27, 2024 •

edited

Loading

home-assistant bot left a comment

bgoncal commented Jun 30, 2024

codecov bot commented Jun 30, 2024 •

edited

Loading

bgoncal commented Jun 30, 2024

bgoncal left a comment

home-assistant bot commented Jul 1, 2024

bgoncal commented Jul 1, 2024

literally-anything commented Jul 2, 2024

bgoncal Jul 3, 2024

bgoncal Jul 5, 2024

bgoncal Jul 5, 2024

bgoncal commented Jul 3, 2024

bgoncal commented Jul 3, 2024

literally-anything commented Jul 3, 2024

bgoncal left a comment

bgoncal commented Jul 8, 2024

literally-anything commented Jul 8, 2024

bgoncal commented Jul 8, 2024

dnestico commented Jul 28, 2024

Add action widgets, open page widgets, and gauges on the Lock Screen #2830

Add action widgets, open page widgets, and gauges on the Lock Screen #2830

Conversation

literally-anything commented Jun 27, 2024 • edited Loading

Summary

Screenshots

Link to pull request in Documentation repository

Any other notes

home-assistant bot left a comment

Choose a reason for hiding this comment

bgoncal commented Jun 30, 2024

codecov bot commented Jun 30, 2024 • edited Loading

Codecov Report

bgoncal commented Jun 30, 2024

bgoncal left a comment

Choose a reason for hiding this comment

home-assistant bot commented Jul 1, 2024

bgoncal commented Jul 1, 2024

literally-anything commented Jul 2, 2024

bgoncal Jul 3, 2024

Choose a reason for hiding this comment

bgoncal Jul 5, 2024

Choose a reason for hiding this comment

bgoncal Jul 5, 2024

Choose a reason for hiding this comment

bgoncal commented Jul 3, 2024

bgoncal commented Jul 3, 2024

literally-anything commented Jul 3, 2024

bgoncal left a comment

Choose a reason for hiding this comment

bgoncal commented Jul 8, 2024

literally-anything commented Jul 8, 2024

bgoncal commented Jul 8, 2024

dnestico commented Jul 28, 2024

literally-anything commented Jun 27, 2024 •

edited

Loading

codecov bot commented Jun 30, 2024 •

edited

Loading